Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portenta: Add BLE support using CYW43XXX generic transport layer #14888

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Portenta: Add BLE support using CYW43XXX generic transport layer #14888

merged 3 commits into from
Jul 9, 2021

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Jul 7, 2021

Summary of changes

This pr add BLE support to PORTENTA target using the generic transport layer of #14227
I've removed 471b3e1 from #14227 and opened this pr to push the changes needed by PORTENTA.

Since in #14663 we have added COMPONENT_4343W_FS macro to keep compatibility with Cypress targets also the BT firmware needs to be moved inside PORTENTA target folder under the COMPONENT_4343W_FS see 7b6d7cd.

Impact of changes

PORTENTA_H7_M7

Migration actions required

Merge after #14227
To run CI this pr need to be rebased after #14227 gets merged

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

Original tests can be found here #14227

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @facchinm

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 7, 2021
@ciarmcom ciarmcom requested review from 0xc0170 and a team July 7, 2021 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 7, 2021

@pennam, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Jul 8, 2021
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 8, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 8, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ❌
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌

@pennam
Copy link
Contributor Author

pennam commented Jul 8, 2021

@0xc0170 ci is failing because this needs to be rebased after #14227 is merged, i'm sorry if i was not clear in the pr description.

@mergify
Copy link

mergify bot commented Jul 8, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 8, 2021

@0xc0170 ci is failing because this needs to be rebased after #14227 is merged, i'm sorry if i was not clear in the pr description.

It's in CI now. This needs a rebase so lets wait until 14227 is in.

@mergify mergify bot dismissed 0xc0170’s stale review July 8, 2021 15:13

Pull request has been modified.

@pennam
Copy link
Contributor Author

pennam commented Jul 8, 2021

rebased, ci should be ok now.

@pennam
Copy link
Contributor Author

pennam commented Jul 8, 2021

I've added the PBL header to w_bt_firmware_controller.c file. I'm not sure it is correct, the file is copy pasted from here /home/pennam/mbed/portenta_patch/mbed-os/connectivity/drivers/ble/FEATURE_BLE/COMPONENT_CYW43XXX/firmware/COMPONENT_4343W

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 0726db0 into ARMmbed:master Jul 9, 2021
@mergify mergify bot removed the ready for merge label Jul 9, 2021
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
@pennam pennam mentioned this pull request Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: connectivity devices: st release-version: 6.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pennam @ciarmcom @0xc0170 @mbed-ci @mbedmain @facchinm